Fix exit code handling in auto-renew function #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code had a critical bug where exit codes from certificate renewal failures were not properly captured due to bash subshell issues with pipelines. When using a pipeline with '|', each command runs in a subshell, so changes to variables inside the while loop don't persist to the parent shell. This fix: - Replaces the pipeline approach with a temporary file to avoid subshell issues - Properly captures and reports failures during certificate renewal - Ensures that if any app fails to renew, the function will correctly report failure instead of always reporting success This is particularly important for automated renewal processes where proper error reporting is critical for monitoring and alerting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code had a critical bug where exit codes from certificate renewal failures were not properly captured due to bash subshell issues with pipelines. When using a pipeline with '|', each command runs in a subshell, so changes to variables inside the while loop don't persist to the parent shell.
This fix:
This is particularly important for automated renewal processes where proper error reporting is critical for monitoring and alerting.