Skip to content

fixing edit record manually creating inconsisten file name / start time #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fixing edit record manually creating inconsisten file name / start time #247

wants to merge 5 commits into from

Conversation

@pedroangelini
Copy link

@pedroangelini pedroangelini commented Feb 18, 2024

Fixes #246 and #89
based on @joshuaherrera 's fix, with the following changes:

  • the new manual edit does not rename the backup file, as it could cause the backup file to be inconsistent (start time <> file name)
  • fixed small bug in askForConfirmation function that did not deal with Windows style new lines ("\r\n")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[bug] Cannot edit a record that had its initial timestamp edited

2 participants

@pedroangelini @joshuaherrera