Fix statistics tracking for bytes sent and received in MqttChannelAdapter#2235
Open
RicoSuter wants to merge 1 commit into
Open
Fix statistics tracking for bytes sent and received in MqttChannelAdapter#2235RicoSuter wants to merge 1 commit into
RicoSuter wants to merge 1 commit into
Conversation
Collaborator
|
This is intentional. It depends on the perspective of the usage of the data. When receiving data, it is the actual sent data by the client. And when the server is sending it is the received data of the client. So when I want to expose the received bytes of the client in the server I have to count the sent bytes and name them received bytes in the client statistics. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
BytesSentandBytesReceivedcounters inMqttChannelAdapterare swapped —ReceivePacketAsyncincrements_bytesSentandSendPacketAsyncincrements_bytesReceived.