Expose Storage.data_ptr() as public API

[alinpahontu2912]

Change the access modifier of Storage.data_ptr() from protected to public, allowing external consumers to obtain the raw data pointer for interop with other native libraries (e.g. bitsandbytes).

Fixes #1454

[alinpahontu2912]

Hey @LittleLittleCloud does this help you?

[Copilot]

Pull request overview

This PR exposes torch.Storage.data_ptr() as a public API so external consumers can obtain the underlying storage pointer for native interop scenarios (e.g., CUDA libraries like bitsandbytes).

Changes:

• Change Storage.data_ptr() visibility from protected to public.
• Add a unit test validating storage<T>().data_ptr() returns a non-zero pointer.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/TorchSharp/Tensor/Storage.cs	Makes data_ptr() public to enable external interop access to the underlying storage pointer.
test/TorchSharpTest/TestTorchTensor.cs	Adds coverage ensuring Storage.data_ptr() returns a non-zero pointer for a basic tensor-backed storage.

Comments suppressed due to low confidence (1)

src/TorchSharp/Tensor/Storage.cs:151

• Now that data_ptr() is public, calling it after Storage.Dispose() will currently throw a NullReferenceException because Dispose() sets _tensor = null and data_ptr() unconditionally dereferences _tensor.Handle. Consider adding an explicit guard (e.g., throw InvalidOperationException) when _tensor is null so the public API fails predictably instead of NRE.

            public IntPtr data_ptr()
            {
                if (_tensor_data_ptr != IntPtr.Zero)
                    return _tensor_data_ptr;

                var res = THSStorage_data_ptr(_tensor.Handle);
                if (res == IntPtr.Zero) { CheckForErrors(); }
                _tensor_data_ptr = res;
                return res;
            }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

src/TorchSharp/Tensor/Storage.cs:172

• Storage.data_ptr() can throw a NullReferenceException when called on a scalar Storage<T> instance (created via the public implicit operator) or after Storage<T>.Dispose(), because _tensor is null and the method calls THSStorage_data_ptr(_tensor.Handle). Since this method is now public API, add an explicit guard (e.g., throw InvalidOperationException/ObjectDisposedException) when _tensor is null.

            public IntPtr data_ptr()
            {
                if (_tensor_data_ptr != IntPtr.Zero)
                    return _tensor_data_ptr;

                var res = THSStorage_data_ptr(_tensor.Handle);
                if (res == IntPtr.Zero) { CheckForErrors(); }
                _tensor_data_ptr = res;
                return res;

src/TorchSharp/Tensor/Storage.cs:172

• The XML docs state callers must not cache the returned pointer and that it becomes invalid if the underlying storage is moved/reallocated/resized, but the implementation caches the pointer in _tensor_data_ptr and always returns the cached value. This can make repeated calls return a stale/invalid pointer after a reallocation; consider either (1) always querying THSStorage_data_ptr (or providing a refresh option) or (2) updating the contract/docs to explicitly state that the pointer is cached and will not update.

            public IntPtr data_ptr()
            {
                if (_tensor_data_ptr != IntPtr.Zero)
                    return _tensor_data_ptr;

                var res = THSStorage_data_ptr(_tensor.Handle);
                if (res == IntPtr.Zero) { CheckForErrors(); }
                _tensor_data_ptr = res;
                return res;

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.