Skip to content

[release/10.0] [mono][interp] Disable inlining of methods that always throw #122594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 1 commit into
base: release/10.0
Choose a base branch
from
Open

[release/10.0] [mono][interp] Disable inlining of methods that always throw #122594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/mono/mono/mini/interp/transform.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8878,10 +8878,10 @@ generate_code (TransformData *td, MonoMethod *method, MonoMethodHeader *header,
memcpy (td->stack, exit_bb->stack_state, exit_bb->stack_height * sizeof(td->stack [0]));
td->sp = td->stack + exit_bb->stack_height;
}
// If exit_bb is not reached by any other bb in this method, just mark it as dead so the
// method that does the inlining no longer generates code for the following IL opcodes.
// If exit_bb is not reached by any other bb in this method, it means the method always
// throws an exception. Inlining it isn't beneficial since this shouldn't be perf sensitive code.
if (exit_bb->in_count == 0)
exit_bb->dead = TRUE;
INLINE_FAILURE;
else
exit_bb->emit_state = BB_STATE_EMITTING;
}
Expand Down
Loading