Skip to content

[wasm][coreclr] Fix DoPrestub for delegates #122596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
radekdoulik wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −0
Open

[wasm][coreclr] Fix DoPrestub for delegates #122596

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f658699
[wasm][coreclr] Fix DoPrestub for delegates
radekdoulik Dec 16, 2025
37df4e0
Update src/coreclr/vm/prestub.cpp
radekdoulik Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/coreclr/vm/prestub.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2367,6 +2367,13 @@ PCODE MethodDesc::DoPrestub(MethodTable *pDispatchingMT, CallerGCMode callerGCMo
{
_ASSERTE(!MayHaveEntryPointSlotsToBackpatch()); // This path doesn't lock the MethodDescBackpatchTracker as it should only
// happen for jump-stampable or non-versionable methods
#ifdef FEATURE_PORTABLE_ENTRYPOINTS
if (pMT->IsDelegate())
{
return pCode;
Copy link
Member

@jkotas jkotas Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we early out here, does it mean that we will be going through PreStub every time the delegate constructor is called? We should not be going through PreStub in steady state as we have discussed...

Copy link
Member Author

@radekdoulik radekdoulik Dec 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not going through PreStub again as the method already has interpreter code after 1st PreStub pass and so we don't call DoPreStub again. OTOH it will leave the method in different state. I will try to better understand the conditions under which we reach the issue and possibly find better solution.

}
#endif // FEATURE_PORTABLE_ENTRYPOINTS

SetCodeEntryPoint(pCode);
}
else
Expand Down