Skip to content

Fix dataflow analysis of lambdas in async methods #122623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichalStrehovsky merged 2 commits into from
Dec 22, 2025
+17 −0
Merged

Fix dataflow analysis of lambdas in async methods #122623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e55e6cc
Fix dataflow analysis of lambdas in async methods
MichalStrehovsky Dec 17, 2025
08ea60c
Update RuntimeAsyncMethods.cs
MichalStrehovsky Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/CompilerGeneratedState.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,6 +737,10 @@ public bool TryGetUserMethodForCompilerGeneratedMember(TypeSystemEntity sourceMe
if (sourceMember == null)
return false;

Debug.Assert(sourceMember is not MethodDesc sourceMethod || sourceMethod.IsTypicalMethodDefinition);
if (sourceMember is AsyncMethodVariant asyncVariant)
sourceMember = asyncVariant.Target;

TypeSystemEntity member = sourceMember;
MethodDesc? userMethodCandidate;
while (TryGetOwningMethodForCompilerGeneratedMember(member, out userMethodCandidate))
Expand Down
13 changes: 13 additions & 0 deletions src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/RuntimeAsyncMethods.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

using System;
using System.Diagnostics.CodeAnalysis;
using System.Reflection;
using System.Runtime.CompilerServices;
using System.Threading.Tasks;
using Mono.Linker.Tests.Cases.Expectations.Assertions;
Expand All @@ -28,6 +29,7 @@ public static async Task Main()
await RuntimeAsyncWithCorrectParameter(null);
await RuntimeAsyncWithLocalAll();
await RuntimeAsyncWithLambda();
await RuntimeAsyncWithAwaitedLocalMethod();
}

static async Task BasicRuntimeAsyncMethod()
Expand Down Expand Up @@ -116,5 +118,16 @@ static async Task RuntimeAsyncWithLambda()
{
await Task.Run([ExpectedWarning("IL2026", nameof(TypeWithRucMethod.RucMethod))] () => typeof(TypeWithRucMethod).GetMethods());
}

static async Task RuntimeAsyncWithAwaitedLocalMethod()
{
await GetTheMethods();

[ExpectedWarning("IL2026", nameof(TypeWithRucMethod.RucMethod))]
static async Task<MethodInfo[]> GetTheMethods()
{
return typeof(TypeWithRucMethod).GetMethods();
}
}
}
}
Loading