Skip to content

Exclude rundownvalidation from crossgen tests - #131829

Merged
jtschuster merged 1 commit into
dotnet:mainfrom
jtschuster:investigate-issue-131662
Aug 5, 2026
Merged

Exclude rundownvalidation from crossgen tests#131829
jtschuster merged 1 commit into
dotnet:mainfrom
jtschuster:investigate-issue-131662

Conversation

@jtschuster

Copy link
Copy Markdown
Member

rundownvalidation requires a MethodILToNativeMap rundown event, but that event is emitted only for JIT-compiled methods. A fully composite ReadyToRun framework and test image can legitimately execute with no eligible JIT methods when tiered compilation is disabled, making this assertion depend on incidental runtime JIT fallback behavior.

Exclude this test from crossgen runs so its assembly remains IL and reliably exercises the JIT-only event, while preserving the existing assertion and process-isolated execution.

Validation:

  • Reproduced the exact scheduled last-good payload passing and first-bad payload failing on Windows x64 Checked with DOTNET_TieredCompilation=0, --composite, and --inputbubble.
  • Isolated the transition to ILCompiler.ReadyToRun.dll from Enable R2R for unresolved static virtual interface calls #131282 using fixed framework inputs and reciprocal compiler DLL swaps.
  • Ran the exact first-bad composite framework payload with test crossgen disabled: the test passed with hasMethodILToNativeMap=True, and no IL-CG2 output was created.

Fixes #131662

Note

This pull request description was generated with GitHub Copilot.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8bca951a-81ba-4d34-a73b-a8f82a228246
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the rundownvalidation test project configuration so it is excluded from CrossGen2/R2R test passes, keeping the test assembly as IL (and thus reliably JIT-compiled) during those runs.

Changes:

  • Disable CrossGen2 compilation for rundownvalidation by setting <CrossGenTest>false</CrossGenTest>.
  • Add an inline comment documenting the rationale for excluding the test from crossgen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

Test failure: tracing/eventpipe/rundownvalidation/rundownvalidation/rundownvalidation.cmd

3 participants