Exclude rundownvalidation from crossgen tests - #131829
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8bca951a-81ba-4d34-a73b-a8f82a228246
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the rundownvalidation test project configuration so it is excluded from CrossGen2/R2R test passes, keeping the test assembly as IL (and thus reliably JIT-compiled) during those runs.
Changes:
- Disable CrossGen2 compilation for
rundownvalidationby setting<CrossGenTest>false</CrossGenTest>. - Add an inline comment documenting the rationale for excluding the test from crossgen.
jkoritzinsky
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rundownvalidationrequires aMethodILToNativeMaprundown event, but that event is emitted only for JIT-compiled methods. A fully composite ReadyToRun framework and test image can legitimately execute with no eligible JIT methods when tiered compilation is disabled, making this assertion depend on incidental runtime JIT fallback behavior.Exclude this test from crossgen runs so its assembly remains IL and reliably exercises the JIT-only event, while preserving the existing assertion and process-isolated execution.
Validation:
DOTNET_TieredCompilation=0,--composite, and--inputbubble.ILCompiler.ReadyToRun.dllfrom Enable R2R for unresolved static virtual interface calls #131282 using fixed framework inputs and reciprocal compiler DLL swaps.hasMethodILToNativeMap=True, and noIL-CG2output was created.Fixes #131662
Note
This pull request description was generated with GitHub Copilot.