Fix handling of inability to get free region in thread_final_regions - #131830
Merged
Conversation
The core currently asserts when get_free_region returns NULL. In release builds, it would just crash. The failure to get free region in the thread_final_regions represents an OOM that is not recoverable at that point. This change replaces the assert by FATAL_GC_ERROR instead.
Member
Author
|
This issue was discovered when investigating #131818 |
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @anicka-net, @dotnet/gc |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates CoreCLR GC region-threading logic to handle get_free_region returning null by treating it as an unrecoverable failure, avoiding debug-only asserts and ensuring a consistent fail-fast behavior.
Changes:
- Replace
assert(start_region)with an explicit null check andFATAL_GC_ERROR()ingc_heap::thread_final_regions.
Member
Author
|
/ba-g the failures are unrelated and known |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core currently asserts when
get_free_regionreturnsNULL. In release builds, it would just crash. The failure to get free region in thethread_final_regionsrepresents an OOM that is not recoverable at that point.This change replaces the assert by
FATAL_GC_ERRORinstead.Close #131818