Skip to content

Remove runtime Helix MSBuild parallelism override #131831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkoritzinsky merged 3 commits into from
Aug 6, 2026
+1 −13
Merged

Remove runtime Helix MSBuild parallelism override #131831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0a259e
Initial plan
Copilot Aug 4, 2026
fa67d51
Remove runtime send-to-helix parallelism override
Copilot Aug 4, 2026
9e38d3c
Inline runtime send-to-helix MSBuild parallelism
Copilot Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions eng/pipelines/common/templates/runtimes/run-test-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,17 +331,6 @@ jobs:

helixProjectArguments: '$(Build.SourcesDirectory)/src/tests/Common/helixpublishwitharcade.proj'

# helixpublishwitharcade.proj processes one scenario per parallel MSBuild invocation. Each invocation only
# creates Helix work items and them waits for their completion on the remote Helix machines, so is not
# computationally intensive. We want Helix to be provided with all the possible work items in up front,
# so can do as much work in parallel as possible. Thus, increase the amount of allowed MSBuild parallelism
# to at least the maximum number of scenarios to be processed in a testGroup.
#
# We only need to do this for a testGroup with more than one or two scenarios, though it isn't functionally
# a problem to always do it. Thus, we only exempt this setting for a few cases.
${{ if notIn(parameters.testGroup, 'innerloop', 'outerloop', 'ilasm', 'gc-longrunning', 'gc-simulator', 'gc-standalone', 'gc-standalone-server') }}:
msbuildParallelism: '/maxcpucount:55'

${{ if in(parameters.testGroup, 'innerloop', 'outerloop') }}:
${{ if and(eq(parameters.runInterpreter, 'true'),eq(variables['Build.Reason'], 'PullRequest')) }}:
scenarios:
Expand Down
3 changes: 1 addition & 2 deletions eng/pipelines/common/templates/runtimes/send-to-helix-step.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ parameters:
helixQueues: ''
helixType: ''
useHelixMonitor: false
msbuildParallelism: '/maxcpucount'
scenarios: ''
timeoutPerTestCollectionInMinutes: ''
timeoutPerTestInMinutes: ''
Expand Down Expand Up @@ -45,7 +44,7 @@ steps:
osGroup: ${{ parameters.osGroup }}
sendParams: >
${{ parameters.helixProjectArguments }}
${{ parameters.msbuildParallelism }}
/m
/bl:$(Build.SourcesDirectory)/artifacts/log/SendToHelix.binlog
/p:TargetArchitecture=${{ parameters.archType }}
/p:TargetOS=${{ parameters.osGroup }}
Expand Down
Loading