Skip to content

Validation only for Node npm Undici 6.29.1 on release/10.0 - #137832

Open
kotlarmilos wants to merge 4 commits into
dotnet:release/10.0from
kotlarmilos:users/mkotlar/node-undici-6.29.1-net10-e2e-26568
Open

kotlarmilos wants to merge 4 commits into
dotnet:release/10.0from
kotlarmilos:users/mkotlar/node-undici-6.29.1-net10-e2e-26568

Conversation

@kotlarmilos

Copy link
Copy Markdown
Member

Description

Validate dotnet/node#448 on release/10.0 using the verified General Testing Node transport 10.0.0-alpha.1.26566.2 and the VMR-produced Emscripten manifest 10.0.116. The validation guards check the provisioned binary hash, npm-bundled Undici fix, and installed workload manifest hash so an older workload cannot pass silently. Node commit 740e4b9484992cf0b6917dfc902939e8652b4041 builds at https://dev.azure.com/dnceng/internal/_build/results?buildId=3137443. VMR commit 01ceffb8ecf00e58755cb5f05a1a6d844beab1b9 builds at https://dev.azure.com/dnceng/internal/_build/results?buildId=3139456. Runtime end-to-end results remain pending. This PR is validation only. Do not merge.

Contributes to dotnet/node#448.

AI-generated with GitHub Copilot.

Consume the verified packages for dotnet/node#448 and fail validation when the provisioned Node binary, npm dependency, or installed VMR manifest differs. This commit is validation only and must not merge.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@kotlarmilos

Copy link
Copy Markdown
Member Author

/azp run runtime-wasm-libtests

AI-generated with GitHub Copilot.

@kotlarmilos

Copy link
Copy Markdown
Member Author

/azp run runtime-wasm

AI-generated with GitHub Copilot.

@azure-pipelines

Copy link
Copy Markdown
No pipelines are associated with this pull request.

1 similar comment
@azure-pipelines

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
12 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@kotlarmilos

Copy link
Copy Markdown
Member Author

/azp run runtime-wasm-libtests

AI-generated with GitHub Copilot.

@kotlarmilos

Copy link
Copy Markdown
Member Author

/azp run runtime-wasm

AI-generated with GitHub Copilot.

@azure-pipelines

Copy link
Copy Markdown
No pipelines are associated with this pull request.

1 similar comment
@azure-pipelines

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@kotlarmilos

Copy link
Copy Markdown
Member Author

/azp run runtime-wasm-libtests

@kotlarmilos

Copy link
Copy Markdown
Member Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

Remove the mapping clear directive so the workload installer can prepend its local package source without NuGet discarding it. Keep the verified Node and VMR package mappings unchanged.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@kotlarmilos

Copy link
Copy Markdown
Member Author

/azp run runtime-wasm

@kotlarmilos

Copy link
Copy Markdown
Member Author

/azp run runtime-wasm-non-libtests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

kotlarmilos and others added 2 commits November 19, 2026 17:44
Preserve the pinned Node packages and VMR workload manifest while incorporating the current target dependencies and updating the matching NuGet source key.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Preserve every Node and VMR workload pin while incorporating the target fix for the missing PlatformDetection member.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant