Repository navigation
Validation only for Node npm Undici 6.29.1 on release/10.0 - #137832
Open
kotlarmilos wants to merge 4 commits into
Open
kotlarmilos wants to merge 4 commits into
kotlarmilos wants to merge 4 commits into
Conversation
Consume the verified packages for dotnet/node#448 and fail validation when the provisioned Node binary, npm dependency, or installed VMR manifest differs. This commit is validation only and must not merge. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
Author
|
/azp run runtime-wasm-libtests AI-generated with GitHub Copilot. |
Member
Author
|
/azp run runtime-wasm AI-generated with GitHub Copilot. |
|
No pipelines are associated with this pull request. |
1 similar comment
|
No pipelines are associated with this pull request. |
|
Azure Pipelines: Successfully started running 3 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Member
Author
|
/azp run runtime-wasm-libtests AI-generated with GitHub Copilot. |
Member
Author
|
/azp run runtime-wasm AI-generated with GitHub Copilot. |
|
No pipelines are associated with this pull request. |
1 similar comment
|
No pipelines are associated with this pull request. |
Member
Author
|
/azp run runtime-wasm-libtests |
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Remove the mapping clear directive so the workload installer can prepend its local package source without NuGet discarding it. Keep the verified Node and VMR package mappings unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
Author
|
/azp run runtime-wasm |
Member
Author
|
/azp run runtime-wasm-non-libtests |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Preserve the pinned Node packages and VMR workload manifest while incorporating the current target dependencies and updating the matching NuGet source key. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Preserve every Node and VMR workload pin while incorporating the target fix for the missing PlatformDetection member. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Validate dotnet/node#448 on
release/10.0using the verified General Testing Node transport10.0.0-alpha.1.26566.2and the VMR-produced Emscripten manifest10.0.116. The validation guards check the provisioned binary hash, npm-bundled Undici fix, and installed workload manifest hash so an older workload cannot pass silently. Node commit740e4b9484992cf0b6917dfc902939e8652b4041builds at https://dev.azure.com/dnceng/internal/_build/results?buildId=3137443. VMR commit01ceffb8ecf00e58755cb5f05a1a6d844beab1b9builds at https://dev.azure.com/dnceng/internal/_build/results?buildId=3139456. Runtime end-to-end results remain pending. This PR is validation only. Do not merge.Contributes to dotnet/node#448.
AI-generated with GitHub Copilot.