[wasm] Remove _UsingBlazorOrWasmSdk condition from browser-wasm workload detection #52250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… property Co-authored-by: maraf <[email protected]>
Copilot
AI
changed the title
[WIP] Remove condition clause from WasmNativeWorkloadNeeded
Remove _UsingBlazorOrWasmSdk condition from browser-wasm workload detection
Dec 19, 2025
maraf
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR synchronizes the SDK's workload manifest logic with changes made in dotnet/runtime#122607, enabling browser-wasm library mode to function without requiring the native workload when using Blazor or WebAssembly SDKs.
Key Changes
- Removed the
'$(_UsingBlazorOrWasmSdk)' != 'true' orcondition from the_WasmNativeWorkloadNeededproperty evaluation in the workload manifest
javiercn
approved these changes
Dec 19, 2025
maraf
deleted the
copilot/remove-conditional-clause-workload-manifest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncs workload manifest logic with dotnet/runtime#122607 and dotnet/runtime#122607 (comment), which enables browser-wasm library mode without requiring the workload.
Changes
'$(_UsingBlazorOrWasmSdk)' != 'true' orcondition from_WasmNativeWorkloadNeededproperty inWorkloadManifest.targets.inThis allows browser-wasm projects to function without the native workload when using Blazor or WebAssembly SDKs, unless other properties explicitly require native features (AOT, native stripping, SIMD configuration, etc.).
The condition previously forced workload requirement for all non-Blazor/non-Wasm SDK scenarios. Now the workload is only needed when specific native features are enabled.
Original prompt
This pull request was created from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.