Skip to content

Fix TabControl spinner button not applying Dark Mode when TabPages added dynamically #14162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeafShi1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix TabControl spinner button not applying Dark Mode when TabPages added dynamically #14162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/System.Windows.Forms/System/Windows/Forms/Controls/TabControl/TabControl.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2068,7 +2068,16 @@ protected override unsafe void WndProc(ref Message m)
case MessageId.WM_REFLECT_MEASUREITEM:
// We use TCM_SETITEMSIZE instead
break;
case PInvokeCore.WM_PARENTNOTIFY:
// Apply dark mode to spinner (updown) button when it's created
if (m.WParamInternal.LOWORD == PInvokeCore.WM_CREATE && Application.IsDarkModeEnabled)
{
HWND childHandle = (HWND)m.LParamInternal;
PInvoke.SetWindowTheme(childHandle, $"{DarkModeIdentifier}_{ExplorerThemeIdentifier}", null);
}

base.WndProc(ref m);
break;
case PInvokeCore.WM_NOTIFY:
case MessageId.WM_REFLECT_NOTIFY:
NMHDR* nmhdr = (NMHDR*)(nint)m.LParamInternal;
Expand Down