Fix cursor editor icon width calculation for proper DPI scaling #14168
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: SimonZhao888 <[email protected]>
…stency Co-authored-by: SimonZhao888 <[email protected]>
Co-authored-by: SimonZhao888 <[email protected]>
Co-authored-by: SimonZhao888 <[email protected]>
Copilot
AI
changed the title
[WIP] Fix cursor editor display issues in propertyGrid for HDPI settings
Fix cursor editor ItemHeight calculation for proper DPI scaling
Dec 24, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14168 +/- ##
===================================================
- Coverage 77.15877% 77.15598% -0.00280%
===================================================
Files 3279 3279
Lines 645333 645333
Branches 47720 47720
===================================================
- Hits 497931 497913 -18
- Misses 143719 143724 +5
- Partials 3683 3696 +13
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
SimonZhao888
changed the title
Member
|
Here is another issue: when the DPI is set to 125%, 175%, 225%, 250%, the .cur icon exhibits an icon offset problem. Offset： |
SimonZhao888
requested review from
KlausLoeffelmann,
LeafShi1,
Shyam-Gupta and
ricardobossan
LeafShi1
reviewed
Jan 8, 2026
| e.DrawBackground(); | ||
| e.Graphics.FillRectangle(SystemBrushes.Control, new Rectangle(e.Bounds.X + 2, e.Bounds.Y + 2, cursorWidth, e.Bounds.Height - 4)); | ||
| e.Graphics.DrawRectangle(SystemPens.WindowText, new Rectangle(e.Bounds.X + 2, e.Bounds.Y + 2, cursorWidth - 1, e.Bounds.Height - 4 - 1)); | ||
| e.Graphics.FillRectangle(SystemBrushes.Control, new Rectangle(e.Bounds.X + 2, e.Bounds.Y + 2, _cursorWidth, e.Bounds.Height - 4)); |
Member
There was a problem hiding this comment.
The _cursorWidth variable is only used within this method, so why is it necessary to define it as a global variable and scale it in the constructor?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14167
Root Cause
Icons similar to HSplit.cur, VSplit.cur are wider than other icons at certain DPI settings (such as 125%, 175%， 225%， 250%), which is causing the webtable to display abnormally.
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
150DPI:
150DPI.mp4
175DPI:
175DPI.mp4
200DPI:
200DPI.mp4
225DPI:
225DPI.mp4
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow