Conversation
…y, fix macro deprecations - Day init(year:month:day:) now throws DayError for invalid inputs - Day stores year, month, dayOfMonth directly alongside daysSince1970 - Removed DayComponents and CalendarDay — CalendarDays is now OrderedDictionary<Day, [Day]> - Fixed deprecated MemberMacro expansion signatures (added conformingTo) - Updated README and CLAUDE.md Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Month and year rolling now uses modular arithmetic to calculate the target month/year, then clamps the day to the last day of that month. This means Jan 31 + 1 month = Feb 28 (or 29) instead of overshooting into March, and Feb 29 + 1 year = Feb 28 in non-leap years. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
day(byAdding:)to use modular arithmetic for month rolling and direct year adjustment, with day clamping to handle shorter months (e.g. Jan 31 + 1 month = Feb 28)Test plan
swift test🤖 Generated with Claude Code