Fix bug in mysql-proxy for empty results on execute path #5023
+2
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am debugging an issue with the Drizzle MySQL proxy. The callback is expected to return a object with three fields: - rows - insertId - affectedRows However, the code handling the callback here destructures the rows field and then expects the insertID and affectedRows field on that. This throws. The doc seem out of date here as well: https://orm.drizzle.team/docs/connect-drizzle-proxy It does mention that on certain `method` a different response is expected. However, I can't validate this in the code and the mode `execute` here is never mentioned in the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am debugging an issue with the Drizzle MySQL proxy. The callback is expected to return a object with three fields:
However, the code handling the callback here destructures the rows field and then expects the insertID and affectedRows field on that.
This throws.
The doc seem out of date here as well:
https://orm.drizzle.team/docs/connect-drizzle-proxy
It does mention that on certain
methoda different response is expected. However, I can't validate this in the code and the modeexecutehere is never mentioned in the docs.