Improved p-values for smooth terms (Wood 2013b). Fixes #163. - #586
Open
vsl366 wants to merge 16 commits into
Open
Improved p-values for smooth terms (Wood 2013b). Fixes #163.#586vsl366 wants to merge 16 commits into
vsl366 wants to merge 16 commits into
Conversation
vsl366
force-pushed
the
gsoc-vsl366
branch
2 times, most recently
from
July 9, 2026 19:37
e4dffb4 to
142a8e6
Compare
This reverts commit 927e78d.
vsl366
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the current method of computing p values in PyGAM with the method mentioned in Simon Wood's "On p-values for smooth components of an extended generalized additive model" (Biometrika 100:221-228), addressing issue #163.