Fixed feature detection in new Cargo build-dir layout - #338
Merged
Conversation
Owner
|
Published in 1.0.119. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Cargo
build-dirlayout.Currently the feature detection silently fails on the new layout as the logic expect a specific file layout.
The build-dir file tree layout is considered an internal implementation detail of Cargo but Cargo also does not yet provide a stable interface to get this information :(
So the approach is keep relying on the Cargo internals but add support for the new v2 layout.
fixes #336
I tested this fix in a reproduction repo https://github.com/ranger-ross/trybuild-336 and it fixes the issue.