[fix #183] add lazy start for sqlite transaction#184
Open
Tangruilin wants to merge 1 commit intoduckdb:mainfrom
Open
[fix #183] add lazy start for sqlite transaction#184Tangruilin wants to merge 1 commit intoduckdb:mainfrom
Tangruilin wants to merge 1 commit intoduckdb:mainfrom
Conversation
Author
|
fix: #183 |
Author
|
brefore: |
Signed-off-by: reilly <tang.ruilin@foxmail.com>
Tangruilin
commented
Mar 28, 2026
| } | ||
|
|
||
| // Slow path: need to open database (on-disk only, with mutex protection) | ||
| lock_guard<mutex> guard(db_mutex); |
Author
There was a problem hiding this comment.
Added mutex in GetDB() to prevent race condition when multiple threads concurrently open the database file - fast path remains lock-free via atomic check. Any alternative suggestions? Or
should we consider not fixing this issue?
Collaborator
|
Hi, thanks for the PR! I will take a look at it. |
staticlibs
reviewed
Mar 30, 2026
Collaborator
staticlibs
left a comment
staticlibs
left a comment
There was a problem hiding this comment.
Hi! I think this implementation may work, but not sure if it goes into the right direction.
I wonder, if instead of delaying opening the DB file even more, we instead can open the file eagerly when ATTACH is called? And keep it open on that catalog instance. Basically to implement the suggestion from this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.