Open
Conversation
Add duckdb.allowed_directories GUC (PGC_SUSET) for allowlisting directories and URL prefixes that remain accessible even when enable_external_access is false. Move enable_external_access from DBConfig struct to a SQL SET in Initialize() so allowed_directories can be applied first (DuckDB rejects changes to allowed_directories after external access is disabled).
adam-lithus
force-pushed
the
feature/allowed-directories-guc
branch
from
3375601 to
c990aac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #884 and #699, this adds
allowed_directoriesto the GUC.Note that DuckDB rejects changes to
allowed_directoriesafter external access is disabled. I've therefore movedenable_external_accessfromDBConfigstruct to a SQL SET in Initialize() soallowed_directoriescan be applied first. Let me know if this is not desirable.Update: CI is passing on our side