feat: honor block size environment#604
Open
ShivamB25 wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #604 +/- ##
==========================================
+ Coverage 85.69% 85.89% +0.19%
==========================================
Files 55 55
Lines 6243 6329 +86
==========================================
+ Hits 5350 5436 +86
Misses 689 689
Partials 204 204 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BLOCK_SIZE, falling back toBLOCKSIZE, across stdout, TUI, and export-progress terminal formattinghuman-readable, andsi; round positive block counts upVerification
go test -v -covermode=count ./...env BLOCK_SIZE=1K go test ./...go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.11.2 run ./internal/common/... ./stdout/... ./tui/... ./report/... ./cmd/gdu/app/... ./cmd/gdu/...BLOCK_SIZE=1KandBLOCKSIZE=kBCloses #120