-
Notifications
You must be signed in to change notification settings - Fork 1.4k
CUR2-642: story dexes #8993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
CUR2-642: story dexes #8993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-dude
approved these changes
Nov 13, 2025
Member
jeff-dude
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks fully fixed to me
Contributor
Author
looks good to me too |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Spellbook 🪄
Please open the PR in draft and mark as ready when you want to request a review.
Description:
[...]
quick links for more information:
Note
Adds Story chain DEX support for Story Hunt v3 and PiperX v2/v3 with models, sources, and seeds, unions them into
dex_story.base_trades, and includes Story in globaldex.base_tradeswhile updatingdex_info.models/trades/story/dex_story_base_trades.sqlcombining Story Hunt v3 and PiperX v2/v3.story/platforms/story_hunt_story_base_trades.sql,piperx_v2_story_base_trades.sql,piperx_v3_story_base_trades.sql.sources/_sector/dex/trades/story/_sources.ymlfor Story Hunt and PiperX events.story_hunt_story_base_trades_seed,piperx_v2_story_base_trades_seed,piperx_v3_story_base_trades_seed.ref('dex_story_base_trades')in global unionmodels/trades/dex_base_trades.sql.story_huntandpiperxentries tomodels/dex_info.sql.models/trades/story/_schema.yml.models/trades/_schema.yml(column list formatting).Written by Cursor Bugbot for commit 0b9662b. Configure here.