Skip to content

Conversation

@tomfutago
Copy link
Contributor

@tomfutago tomfutago commented Nov 11, 2025

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

[...]


quick links for more information:


Note

Adds Story chain DEX support for Story Hunt v3 and PiperX v2/v3 with models, sources, and seeds, unions them into dex_story.base_trades, and includes Story in global dex.base_trades while updating dex_info.

  • Story chain DEX support
    • New base union models/trades/story/dex_story_base_trades.sql combining Story Hunt v3 and PiperX v2/v3.
    • New platform models: story/platforms/story_hunt_story_base_trades.sql, piperx_v2_story_base_trades.sql, piperx_v3_story_base_trades.sql.
    • New sources in sources/_sector/dex/trades/story/_sources.yml for Story Hunt and PiperX events.
    • New seeds and schema entries for: story_hunt_story_base_trades_seed, piperx_v2_story_base_trades_seed, piperx_v3_story_base_trades_seed.
  • Integration
    • Include ref('dex_story_base_trades') in global union models/trades/dex_base_trades.sql.
    • Add story_hunt and piperx entries to models/dex_info.sql.
  • Schema
    • Add model tests and metadata in models/trades/story/_schema.yml.
    • Minor cleanup in models/trades/_schema.yml (column list formatting).

Written by Cursor Bugbot for commit 0b9662b. Configure here.

@tomfutago tomfutago self-assigned this Nov 11, 2025
@github-actions github-actions bot added WIP work in progress dbt: dex covers the DEX dbt subproject labels Nov 11, 2025
@jeff-dude jeff-dude marked this pull request as ready for review November 13, 2025 19:47
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Nov 13, 2025
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fully fixed to me

@jeff-dude jeff-dude assigned jeff-dude and unassigned tomfutago Nov 13, 2025
@jeff-dude jeff-dude added ready-for-merging and removed ready-for-review this PR development is complete, please review labels Nov 13, 2025
@tomfutago
Copy link
Contributor Author

this looks fully fixed to me

looks good to me too

@jeff-dude jeff-dude merged commit db4cd45 into main Nov 14, 2025
2 of 3 checks passed
@jeff-dude jeff-dude deleted the CUR2-642-story-dexes branch November 14, 2025 16:52
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dbt: dex covers the DEX dbt subproject ready-for-merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants