Merged
Conversation
benbierens
force-pushed
the
chore/cleanup-compile-flags
branch
from
eebb86b to
43f5cf4
Compare
markspanbroek
approved these changes
Oct 27, 2025
Contributor
markspanbroek
left a comment
markspanbroek
left a comment
There was a problem hiding this comment.
Nice @benbierens, cleans up nicely! Left a comment
| response = await client.post(url, headers = headers, body = "") | ||
| assert response.status == 200 | ||
|
|
||
| proc setSto*( |
Contributor
There was a problem hiding this comment.
Perhaps rename to setSystemTestingOption()? And rename the rest endpoint to /debug/option/, or /debug/testing/option?
benbierens
force-pushed
the
chore/cleanup-compile-flags
branch
from
43f5cf4 to
1bfeb32
Compare
veaceslavdoina
changed the title
benbierens
force-pushed
the
chore/cleanup-compile-flags
branch
from
10fd232 to
ef8e95d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There three different compile flags that enable features used for testing. This PR combines them into a single flag.
It also introduces a generic system-testing-options API call by which these testing features can be controlled, replacing constants or cli-arguments, allowing for more flexible test scenarios.