-
-
Notifications
You must be signed in to change notification settings - Fork 5
feat(bootstrap): generate confidence interval with bootstrap #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
shenxiangzhuang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please give some suggestions about this implementation and I'd like to improve it further.
|
As mentioned in #20, I recommend taking a step back from rushing into implementing the idea and instead focusing on developing the API usage examples first. It might be best to structure this as a wrapper function around the score computation function, ensuring it remains flexible and not tied to specific arguments passed to the estimator. |
|
Hi @dustalov , I have reimplemented this feature according to the discussion in #20 (sure it need more friendly doc and tests, and I'll do these later:). Is there any suggestion for this until now? ps: I found that using scipy.stats.bootstrap is not that straightforward as I thought before, so I just use |
|
Hi, apologies for the delayed review. While this implementation is straightforward, SciPy's version is intentionally more complex, likely for good reason. I would like to take some time to think it through—code in Evalica should provide clear added value. How urgent is this pull request? |
|
Never mind, no rush~ |
Close #20