Skip to content

Conversation

@shenxiangzhuang
Copy link
Contributor

Close #20

@shenxiangzhuang shenxiangzhuang marked this pull request as draft December 14, 2024 13:19
Copy link
Contributor Author

@shenxiangzhuang shenxiangzhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please give some suggestions about this implementation and I'd like to improve it further.

@dustalov
Copy link
Owner

As mentioned in #20, I recommend taking a step back from rushing into implementing the idea and instead focusing on developing the API usage examples first.

It might be best to structure this as a wrapper function around the score computation function, ensuring it remains flexible and not tied to specific arguments passed to the estimator.

@shenxiangzhuang
Copy link
Contributor Author

shenxiangzhuang commented Feb 20, 2025

Hi @dustalov , I have reimplemented this feature according to the discussion in #20 (sure it need more friendly doc and tests, and I'll do these later:). Is there any suggestion for this until now?

ps: I found that using scipy.stats.bootstrap is not that straightforward as I thought before, so I just use np.quantile for for loop to do this now.

@dustalov
Copy link
Owner

dustalov commented May 9, 2025

Hi, apologies for the delayed review. While this implementation is straightforward, SciPy's version is intentionally more complex, likely for good reason. I would like to take some time to think it through—code in Evalica should provide clear added value. How urgent is this pull request?

@shenxiangzhuang
Copy link
Contributor Author

Never mind, no rush~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate confidence interval with bootstrap

2 participants