-
Notifications
You must be signed in to change notification settings - Fork 1.9k
use imported directory as project path #894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cubic analysis
No issues found across 2 files. Review in cubic
|
I think this change makes sense, but there's a bunch of E2E test failing. if you want to try and fix them that'll be very helpful, otherwise, I can look at this later. |
|
I would be happy to help! Unfortunately, Github CI shows empty logs. |
The logs don't seem to be empty now, there are errors like this in the run here |
| handle("check-app-name", async (_, { appName }: { appName: string }) => { | ||
| // Check filesystem | ||
| const appPath = getDyadAppPath(appName); | ||
| try { | ||
| await fs.access(appPath); | ||
| return { exists: true }; | ||
| } catch { | ||
| // Path doesn't exist, continue checking database | ||
| } | ||
|
|
||
| // Check database | ||
| // Only check the database since we no longer copy to a fixed path | ||
| const existingApp = await db.query.apps.findFirst({ | ||
| where: eq(apps.name, appName), | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The check-app-name handler currently only validates if the app name exists in the database, but it should also verify if the provided source path already exists in any app record. Since the implementation now uses the original path instead of copying to a fixed location, a user could receive misleading feedback where the name check passes but the subsequent import operation fails due to a path conflict. Consider adding path uniqueness validation to this handler to provide more accurate feedback earlier in the process.
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you like me to do that?
|
Sorry for the delay! The error you see doesn't seem to come from the PR itself, except if i misunderstood something. @antont |
Description
This pull request keeps the same path as the imported project, instead of duplicating it into
dyad-appsfolder.