Repository navigation
fix: do not double-bump pre* increments from a prerelease - #1
Open
dyk1454683243-sudo wants to merge 1 commit into
Open
dyk1454683243-sudo wants to merge 1 commit into
dyk1454683243-sudo wants to merge 1 commit into
Conversation
premajor, preminor, and prepatch now compose as major/minor/patch followed by pre, matching the docs and avoiding an extra version jump when the input is already a prerelease of that release type. Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / Why
premajor,preminor, andprepatchjumped an extra version when the input was already a prerelease of that release type.The docs say these operations bump to the next major/minor/patch and then down to a prerelease of that version. Isolated steps already do the right thing:
but
inc('2.0.0-pre', 'premajor')returned3.0.0-0.This change makes
premajor/preminor/prepatchcompose asmajor/minor/patchfollowed bypre, so they reuse the existing “already a prerelease of this type” logic and no longer double-bump.Upstream PR: npm#903
Tests
2.0.0-pre→2.0.0-0, plus preminor/prepatch analogs)npx tap: 51 files, 100% coverageReferences
Fixes npm#751