🔧 use confirmed trips for agg metrics #1054
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Step 1 of e-mission/e-mission-docs#1126 is to simply use confirmed trips instead of composite trips to compute metrics. Confirmed trips are smaller than composite trips, so this will use less memory. e-mission-common is already set up to handle both types the same way. Testing done: e-mission/e-mission-docs#1126 (comment)
shankari
approved these changes
Apr 24, 2025
Contributor
shankari
left a comment
shankari
left a comment
There was a problem hiding this comment.
This is approved, but I am going to keep it in my "back pocket" while seeing how long it takes to implement the "cache once a day, as part of the public dashboard" solution.
shankari
force-pushed
the
master
branch
4 times, most recently
from
a2a9a44 to
e50e9f3
Compare
shankari
force-pushed
the
master
branch
3 times, most recently
from
cd45974 to
30c4273
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1 of e-mission/e-mission-docs#1126 is to simply use confirmed trips instead of composite trips to compute metrics. Confirmed trips are smaller than composite trips, so this will use less memory. e-mission-common is already set up to handle both types the same way.
Testing done:
e-mission/e-mission-docs#1126 (comment)