Skip to content

Conversation

@TeachMeTW
Copy link
Contributor

@TeachMeTW TeachMeTW commented Apr 24, 2025

This PR adds comprehensive test coverage for recent changes:

Mode Inference Testing:

  • Adds TestRuleEngine.py with test cases for rule-based mode inference
  • Includes multiple test scenarios to verify rule engine classification
  • Tests various edge cases and known scenarios from real data

Transit Matching Tests:

  • Implements TestMatchStops.py with full test coverage for transit stop matching
  • Validates the caching mechanism functionality
  • Ensures consistent behavior with and without cached results

Updated Test Data:

  • Regenerated ground truth files for rule engine compatibility
  • Added additional test data for transit matching scenarios
  • Updated expected data files to match new inference behavior

Reference:
Original PR was split to separate implementation from tests for easier review and integration.

THIS WILL FAIL DUE TO THE OTHER PR HAVING THE NECESSARY CODE

@TeachMeTW TeachMeTW changed the title Add test coverage for rule_engine mode inference and transit matching Test-Only Changes for Rule Engine Apr 24, 2025
@TeachMeTW TeachMeTW force-pushed the pr_split_tests_only branch from 8415e45 to 3bbe262 Compare April 25, 2025 01:53
@TeachMeTW TeachMeTW marked this pull request as ready for review April 25, 2025 02:04
@TeachMeTW TeachMeTW marked this pull request as draft April 25, 2025 20:37
@TeachMeTW TeachMeTW marked this pull request as ready for review April 29, 2025 06:23
@shankari shankari force-pushed the master branch 4 times, most recently from a2a9a44 to e50e9f3 Compare June 4, 2025 15:34
@shankari shankari force-pushed the master branch 3 times, most recently from cd45974 to 30c4273 Compare September 5, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant