Skip to content

Questionnaire management#2587

Open
ZoqkMaze wants to merge 17 commits intoe-valuation:mainfrom
ZoqkMaze:q_management
Open

Questionnaire management#2587
ZoqkMaze wants to merge 17 commits intoe-valuation:mainfrom
ZoqkMaze:q_management

Conversation

@ZoqkMaze
Copy link
Copy Markdown
Collaborator

@ZoqkMaze ZoqkMaze commented Dec 15, 2025 •
edited
Loading

fix #2545

niklasmohrin
niklasmohrin reviewed Dec 17, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want to get feedback yet? I took only a very quick look over the changes so far

Comment thread evap/evaluation/migrations/0159_merge_20251215_2018.py Outdated
Comment thread evap/staff/templates/staff_questionnaire_index_list.html Outdated
@ZoqkMaze
Copy link
Copy Markdown
Collaborator Author

ZoqkMaze commented Dec 23, 2025

do you want to get feedback yet? I took only a very quick look over the changes so far

Yes, please. Hopefully, only one test is missing

@niklasmohrin
Copy link
Copy Markdown
Member

niklasmohrin commented Jan 11, 2026 •
edited
Loading

@hansegucker @fekoch @jooooosef @ybrnr I won't find time to review this before I am there tomorrow, and by then I expect that other things will have come up. Can some of you give a review round or two on this? Maybe if you have some time tomorrow at the meeting :)

ybrnr
ybrnr suggested changes Jan 12, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ybrnr ybrnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should also run ./manage.py precommit

Comment thread evap/staff/templates/staff_questionnaire_index.html Outdated
richardebeling
richardebeling reviewed Jan 12, 2026
View reviewed changes
Comment thread evap/staff/templates/staff_questionnaire_index.html Outdated
jooooosef
jooooosef suggested changes Jan 12, 2026
View reviewed changes
Comment thread evap/staff/forms.py Outdated
Comment thread evap/staff/templates/staff_questionnaire_index.html
Comment thread evap/evaluation/tools.py
Comment thread evap/staff/views.py Outdated
Comment thread evap/staff/views.py Outdated
Comment thread evap/static/scss/_adjustments.scss Outdated
niklasmohrin
niklasmohrin reviewed Jan 25, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but there are some rough corners we should still fix

Comment thread evap/staff/templates/staff_questionnaire_index.html Outdated
Comment thread evap/staff/templates/staff_questionnaire_index.html Outdated
Comment thread evap/staff/templates/staff_questionnaire_index.html Outdated
Comment thread evap/staff/templates/staff_questionnaire_index.html Outdated
Comment thread evap/staff/templates/staff_questionnaire_index.html Outdated
Comment thread evap/staff/views.py Outdated
Comment thread evap/staff/views.py Outdated
Comment thread evap/staff/views.py Outdated
Comment thread evap/staff/views.py Outdated
Comment thread evap/static/scss/_adjustments.scss Outdated
@ZoqkMaze ZoqkMaze requested a review from niklasmohrin January 27, 2026 00:20
fekoch
fekoch suggested changes Feb 2, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fekoch fekoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janno42 and me rethought about the "All" - "Visible" - "Non-Archived" filter-buttons. Can you change them to be the following:

  1. "All" (the default) should show all non-archived questionnaires
  2. "Visible": same as before
  3. "Archived": only archived questionaires

richardebeling
richardebeling reviewed Feb 14, 2026
View reviewed changes
Comment thread evap/staff/templates/staff_questionnaire_index.html Outdated
Comment thread evap/staff/templates/staff_questionnaire_index.html Outdated
Comment thread evap/staff/templates/staff_questionnaire_index.html
Comment thread evap/staff/templates/staff_questionnaire_index_list.html
Comment thread evap/staff/tests/test_views.py Outdated
Comment thread evap/staff/tests/test_views.py Outdated
Comment thread evap/staff/tests/test_views.py Outdated
Comment thread evap/static/scss/_adjustments.scss Outdated
Comment thread evap/static/scss/_adjustments.scss Outdated
Comment thread evap/staff/views.py
@niklasmohrin niklasmohrin removed their request for review February 16, 2026 23:09
@richardebeling richardebeling requested a review from janno42 March 2, 2026 19:03
janno42
janno42 requested changes Mar 2, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@janno42 janno42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the text "There are no matching questionnaires" and instead keep the empty table (with header). We will address the handling of empty tables in a separate issue.

niklasmohrin
niklasmohrin requested changes Mar 5, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to work as expected, some small comments on the code

Comment thread evap/evaluation/tools.py Outdated
Comment thread evap/staff/tests/test_live.py
Comment thread evap/staff/templates/staff_questionnaire_index.html Outdated
Comment thread evap/staff/templates/staff_questionnaire_index_list.html
@niklasmohrin
Copy link
Copy Markdown
Member

niklasmohrin commented Mar 5, 2026

Note that we still have an "There are no questionnaires yet." with no table at all if there are no questionnaires in any of the tabs; @janno42 do you want this one to also go away?

@ZoqkMaze ZoqkMaze requested a review from janno42 March 30, 2026 16:38
janno42
janno42 requested changes Apr 13, 2026
View reviewed changes
Comment thread evap/staff/templates/staff_questionnaire_index.html Outdated
Comment thread evap/staff/templates/staff_questionnaire_index.html Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janno42 janno42 janno42 requested changes

@niklasmohrin niklasmohrin niklasmohrin requested changes

@richardebeling richardebeling richardebeling approved these changes

+3 more reviewers

@ybrnr ybrnr ybrnr requested changes

@jooooosef jooooosef jooooosef requested changes

@fekoch fekoch fekoch approved these changes

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Questionnaire management

7 participants

@ZoqkMaze @niklasmohrin @janno42 @richardebeling @fekoch @ybrnr @jooooosef