Skip to content

create custom tooltip for questionnaire#2676

Open
geromequa wants to merge 3 commits intoe-valuation:mainfrom
geromequa:2591-questionnaire-tooltip-positioning
Open

create custom tooltip for questionnaire#2676
geromequa wants to merge 3 commits intoe-valuation:mainfrom
geromequa:2591-questionnaire-tooltip-positioning

Conversation

@geromequa
Copy link
Copy Markdown
Collaborator

@geromequa geromequa commented Mar 16, 2026

Closes #2591.

@geromequa geromequa marked this pull request as ready for review March 30, 2026 18:49
@geromequa
Copy link
Copy Markdown
Collaborator Author

Failed Test is known flaky test (see #2652).

Comment thread evap/evaluation/templates/base.html Outdated
Comment thread evap/evaluation/templates/base.html Outdated

const questionnaireTooltipOptions = {
template: '<div class="tooltip py-2" role="tooltip"><div class="tooltip-inner"></div></div>',
popperConfig: config => {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking up the actual documentation: It seems like we may not actually change the object we get here, but should create a new object.

https://getbootstrap.com/docs/5.0/components/popovers/#using-function-with-popperconfig

I still don't really get what specific usage pattern they want us to use here, guess we'll have to check their code a bit.

@richardebeling richardebeling self-requested a review April 13, 2026 20:17
Copy link
Copy Markdown
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm, haven't tested the page

return config;
}
};
activateTooltips("","questionnaire-tooltip", questionnaireTooltipOptions);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
activateTooltips("","questionnaire-tooltip", questionnaireTooltipOptions);
activateTooltips("", "questionnaire-tooltip", questionnaireTooltipOptions);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Questionnaire preview tooltip positioning

2 participants