Student vote page: red border for erroneous rows is missing #2692#2700
Open
anjaton wants to merge 2 commits intoe-valuation:mainfrom
Open
Student vote page: red border for erroneous rows is missing #2692#2700anjaton wants to merge 2 commits intoe-valuation:mainfrom
anjaton wants to merge 2 commits intoe-valuation:mainfrom
Conversation
Member
richardebeling
left a comment
richardebeling
left a comment
There was a problem hiding this comment.
Looks mostly good, thanks! There's two small white space changes, can you revert them?
| border-color: $evap-red; | ||
| } | ||
| border-color: $evap-red !important; | ||
| } No newline at end of file |
Member
There was a problem hiding this comment.
You removed a trailing newline character here. Please add it back
Member
There was a problem hiding this comment.
The line terminator for the last line is still missing. For details on why we want it, see https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline.
I would guess that your editor automatically removed the last newline character. If you're using VSCode, check that it doesn't have trimFinalNewlines enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2692