Layered Exceptions#76
Merged
Merged
Conversation
… exception originates from
Updated solution to include new project for data . Updated solution to include existing project for logic. Modified CI/CD pipeline to include jobs for new projects. Established project references and dependencies in relevant files. Introduced custom exception classes for data and logic errors. Initialized E13.Common.Data project with .NET 9.0 settings.
Updated README.md to include a new section for the E13.Common.Data package. This includes an overview, features, installation instructions, dependencies, related packages, contribution guidelines, and licensing information to improve documentation and usability.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces new exception classes across the E13.Common projects while updating project references and continuous deployment configuration, and adding documentation for the new Data project.
- Added new exception classes (LogicException, DomainException, and DataException).
- Updated solution and build/CD configurations to incorporate new projects and proper pipeline ordering.
- Added a README.md for E13.Common.Data with package details.
Reviewed Changes
Copilot reviewed 5 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/E13.Common.Logic/LogicException.cs | Introduces LogicException with standard exception constructors. |
| src/E13.Common.Domain/DomainException.cs | Introduces DomainException without additional constructors. |
| src/E13.Common.Data/DataException.cs | Introduces DataException without additional constructors. |
| src/E13.Common.Data/docs/README.md | Provides documentation for the new E13.Common.Data project. |
| build/cd.yml | Updates project references and stage dependencies in the pipeline. |
Files not reviewed (4)
- E13.Common.sln: Language not supported
- doc/E13.Common.Core.xml: Language not supported
- src/E13.Common.Data.Db/E13.Common.Data.Db.csproj: Language not supported
- src/E13.Common.Data/E13.Common.Data.csproj: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes multiple changes to the
E13.Commonproject, focusing on adding new projects and updating continuous deployment configurations. Additionally, it introduces new exception classes and updates documentation.Project and Solution Updates:
E13.Common.DataandE13.Common.Logicto the solution fileE13.Common.sln.E13.Common.DataandE13.Common.Logicin build configurations. [1] [2]Continuous Deployment Configuration:
build/cd.ymlto adjust project references and stages, ensuring proper build and deployment of the new projects. [1] [2] [3] [4]Documentation Updates:
README.mdforE13.Common.Datadetailing its purpose, features, installation, dependencies, related packages, contribution guidelines, and license.New Exception Classes:
DataExceptioninE13.Common.Data.DomainExceptioninE13.Common.Domain.LogicExceptioninE13.Common.Logicwith multiple constructors for different use cases.Project References:
E13.Common.DatainE13.Common.Data.Db.csproj.E13.Common.Datatargeting .NET 9.0.