Adding Async versions of the overridden methods#80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
SavingChangesmethods in three database interceptors (CreatableInterceptor,ModifiableInterceptor, andSoftDeleteInterceptor) to improve code reuse and add asynchronous support. The changes include introducing a sharedHandleEventDatamethod in each class and implementing theSavingChangesAsyncmethod for better handling of asynchronous database operations.Refactoring for code reuse and consistency:
HandleEventDatamethod inCreatableInterceptor,ModifiableInterceptor, andSoftDeleteInterceptorto handle entity state changes consistently. This method processes theChangeTrackerentries based on the specific entity types (ICreatable,IModifiable,IDeletable) and updates their audit fields. [1] [2] [3]Asynchronous support:
SavingChangesAsyncmethods to all three interceptors (CreatableInterceptor,ModifiableInterceptor,SoftDeleteInterceptor) to handle asynchronous database save operations, leveraging theCancellationTokenparameter for cancellation support. [1] [2] [3]Minor improvements:
dataparameter toeventDatainSavingChangesmethods for better clarity and alignment with naming conventions. [1] [2] [3]