Skip to content

[CI only] build/skip-emulated-stages on develop - #14

Closed
e7d wants to merge 7 commits into
developfrom
build/skip-emulated-stages
Closed

e7d wants to merge 7 commits into
developfrom
build/skip-emulated-stages

Conversation

@e7d

@e7d e7d commented Nov 7, 2026

Copy link
Copy Markdown
Owner

Temporary draft, closed once CI has run. The workflow only runs for pull requests targeting develop or master, so the stacked PRs #11 and #12 get no CI of their own. This draft runs it on the cumulative state this branch would put on develop.

Not to be merged: the stack (#10 → #11 → #12) is.

dependabot Bot and others added 7 commits November 3, 2026 05:14
Bumps [symfony/yaml](https://github.com/symfony/yaml) from 6.4.40 to 6.4.45.
- [Release notes](https://github.com/symfony/yaml/releases)
- [Changelog](https://github.com/symfony/yaml/blob/8.2/CHANGELOG.md)
- [Commits](symfony/yaml@v6.4.40...v6.4.45)

---
updated-dependencies:
- dependency-name: symfony/yaml
  dependency-version: 6.4.45
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
minify.sh ran html-minifier and uglify-es through npx without a
version, so every build fetched the latest release. html-minifier
5.0.0 (2026-11-03) dropped --remove-script-type-attributes, and the
scheduled builds have failed since.

Pin html-minifier to 4.0.0 and uglify-es to 3.3.10, the versions the
image was built with until then.
escape() returned an empty string for anything but a string since the
XSS fix (c49496f). Latitude and longitude are floats and the AS number
is an int, so the HTML page showed ", " as coordinates and "AS <org>"
without the number, while the links built from the raw values stayed
correct.

Accept ints and floats and escape their string form; other types still
render empty.
minify.sh ran uglify-js, css-minify and html-minifier through npx
without a version, so every build fetched the latest release.
html-minifier 5.0.0 (2026-11-03) dropped --remove-script-type-attributes
and the builds have failed since.

Pin the three to the versions the last successful develop build used:
uglify-js 3.19.3, css-minify 2.1.0, html-minifier 4.0.0.
fix(): pin minifier versions in the HTML build
…nd-escape

# Conflicts:
#	composer.lock
#	docker/build/minify.sh
The arm64 image is built under QEMU, and every stage ran once per
platform. On the last cold build, emulated arm64 spent 346s compiling
geoipupdate, 81s minifying and 45s in composer, against 60s, 6s and 14s
on amd64.

composer and the minifiers produce the same files on every platform, so
both stages now run once on the build platform. geoipupdate is copied
from MaxMind's multi-arch image instead of compiled, pinned by digest
to v4.11.1, the version `go install …/v4/…@latest` resolved to.
@e7d

e7d commented Nov 7, 2026

Copy link
Copy Markdown
Owner Author

Redundant: creating the stack triggered CI on #11 and #12 directly.

@e7d e7d closed this Nov 7, 2026
@e7d
e7d deleted the build/skip-emulated-stages branch November 7, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant