Skip to content

Create lockfile for Cargo package if missing #3995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Flamefire wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Create lockfile for Cargo package if missing #3995

Flamefire wants to merge 10 commits into from
+392 −34

Conversation

@Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Nov 21, 2025 •
edited
Loading

@Flamefire
Implement more complete TOML parser in Cargo easyblock
83ee144 
Loosely parse everything that could be in a Cargo.toml file
@Flamefire
Accept parsed TOML file in get_workspace_members
d57b376 
Allow reusing the parsed result.
@Flamefire
Correctly handle multiline strings
0a86a05 
When there is a line
> key = """

the value starts and ends with the delimitter wrongly terminating the
value parser.
Check that there is anything else first.
@Flamefire
Make comment handling more resilient
e8fcd04 
'#'-signs can be embedded in strings
@Flamefire
Implement merging Cargo.toml file with workspace file
fb11ab3 
Resolve backreferences like `authors.workspace = true`
@Flamefire
Avoid B007 hound warning
50602d7 
We use the line number only outside the loop which triggers
> Loop control variable 'num' not used within the loop body. If this is intended, start the name with an underscore.
@Flamefire
Also handle dict-syntax for "workspace=true"
18f8c2a
@Flamefire
Fix for TOML files having only a dict-style workspace reference
5b1a5ff
@Flamefire
Fix too greedy match for replacing workspace value
78e5c3c
@Flamefire
Create lockfile for Cargo package if missing
66b2862
@Flamefire Flamefire force-pushed the 20251121090749_new_pr_cargo branch from de3fe7d to 66b2862 Compare November 21, 2025 08:11
This was referenced Nov 21, 2025
Open
Open
@boegel boegel added this to the release after 5.2.0 milestone Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

release after 5.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Flamefire @boegel