Some minor (but breaking) suggestions for `categorize()`

[mattansb]

1. Current behavior is to return an integer vector. To be consistent with cut(), and to be safer to use, I think this function should return by default a factor - possible an ordered factor.
   • also I think we can drop the lowest argument?
2. The breaks argument in R is usually used to provide the breaking values - here if those are done manually, they are sent to split instead.
3. Rename split to method?
4. 4. We should add a right = TRUE argument, like with cut().

[strengejacke]

We should add a right = TRUE argument, like with cut().

The right argument is handled like this: cut(..., right = identical(breaks, "inclusive")).

Rename split to method?

split currently also accept a numeric vector with values that define the splits, thus, I'd say a method argument is not fully appropriate?

Current behavior is to return an integer vector. To be consistent with cut(), and to be safer to use, I think this function should return by default a factor - possible an ordered factor.

Not for factors, only for numerics. When you use the labels argument, a factor is always returned.