Repository navigation
Print footer line for prediction intervals - #673
Merged
strengejacke merged 5 commits intoOct 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Moderate findings remain, including potentially incorrect footer output and an outdated brms snapshot.
1 open finding
What changed in this PR
Adds a footer identifying prediction intervals based on the effective prediction type.
Changes:
- Adds prediction-interval footer logic.
- Propagates effective prediction metadata.
- Adds tests and updates NEWS/version metadata.
| File | Summary |
|---|---|
tests/testthat/test-table_footer.R |
Adds footer behavior tests. |
R/table_footer.R |
Prints the new footer; moderate issues remain around selected columns, ambiguous CI_low names, and the brms snapshot. |
R/estimate_predicted.R |
Passes effective prediction metadata to the footer. |
NEWS.md |
Documents the change. |
DESCRIPTION |
Increments the development version. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Intervals are prediction intervals.to the footer when the printed intervals are prediction intervals (estimate_prediction(), orpredict = "prediction"). The footer reads thepredictattribute returned byinsight::get_predicted(), so models where insight falls back to expectations (e.g. glmmTMB, gam) don't get the line.The brms Wiener snapshots (
tests/testthat/_snaps/brms.md) are updated with the new line.test-brms.R:26fails for me onmaintoo, so that one is unrelated.Closes #485