Open
Conversation
|
|
Contributor
Author
|
So I did all this work, and then decided to check if someone else had done it, and it seems both @wash2 ( #798 ) and @PedroVH ( #1064 ) have done this earlier. Guess I should have checked first. Anyway, I think hopefully this should be more sophisticated, since it doesn't assume any hardcoded paths, allows the user to configure things and shows up an error if it isn't configured correctly. Also, full disclosure, I've only tested this on Lethal Company, and I'm super unfamiliar with typescript. |
RossBrunton
force-pushed
the
flatpak
branch
2 times, most recently
from
0e76749 to
a9ed932
Compare
Contributor
Author
|
Is there anything blocking this from being accepted? |
|
Why has this not been merged yet? |
RossBrunton
force-pushed
the
flatpak
branch
2 times, most recently
from
24084f9 to
545b22b
Compare
RossBrunton
force-pushed
the
flatpak
branch
2 times, most recently
from
29e4532 to
0fd403e
Compare
This adds a configuration setting "linuxUseFlatpak" which controls whether Steam should be launched as a Flatpak or not. By default this is detected automatically based on the path, but an option in the settings can override the behaviour. If this option is enabled, we first check if we are able to read from our config directory. If not, we display an error and ask the user to give us permission. If we do, then we launch Steam through flatpak rather than the binary directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a configuration setting "linuxUseFlatpak" which controls whether Steam should be launched as a Flatpak or not. By default this is detected automatically based on the path, but an option in the settings can override the behaviour.
If this option is enabled, we first check if we are able to read from our config directory. If not, we display an error and ask the user to give us permission. If we do, then we launch Steam through flatpak rather than the binary directly.
Closes: #1144, #1051