Skip to content

Conversation

@haydar-metin
Copy link
Contributor

@haydar-metin haydar-metin commented Mar 23, 2025

What it does

Closes eclipse-glsp/glsp#1458
Should improve flakiness.

  1. Wait for the tool palette to be ready (domain specific information)
  2. Use a function call for expect(...).toHaveSelected(...) to delay execution
  3. Introduce graph.waitForReplacement that will wait until the provided element has been replaced with a new one.
  4. Reduce clutter in locating diagram elements (see graph)
  5. Updates approach for waitForCreation by using Playwright API instead of directly polling for elements by using JavaScript.
  • Introduces waitForReplacement and waitForHide
  1. GLSPLocator now supports accessing the root + has helper utils.

How to test

Follow-ups

Changelog

  • This PR should be mentioned in the changelog

  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

  • Updates constructor of BaseRoutingPoint to be object based.

  • packages/glsp-playwright/src/glsp/graph/graph.wait.ts - removed, not necessary anymore.

@haydar-metin haydar-metin requested a review from tortmayr March 23, 2025 10:29
@haydar-metin haydar-metin self-assigned this Mar 23, 2025
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, and test seem to be way more stable now. Good job! 👍🏼

@tortmayr tortmayr merged commit 584c57e into eclipse-glsp:main Mar 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Theia] Investigate flaky E2E Tests

2 participants