Skip to content

Invert conditions in PackageFragment.validateExistence(IResource) #4343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Invert conditions in PackageFragment.validateExistence(IResource) #4343

wants to merge 1 commit into from
+3 −5

Conversation

@fedejeanne
Copy link
Contributor

@fedejeanne fedejeanne commented Aug 21, 2025

Check if the package is excluded before asking for its kind (the latter might be expensive).

Contributes to eclipse-jdt/eclipse.jdt.ui#1860

See #4342 (comment)

Maybe even !Util.isExcluded(this) could go before super.exists(), but since that one uses this and I'm not sure if it depends on its current state, I didn't risk it.

@fedejeanne
Invert conditions in PackageFragment.validateExistence(IResource)
6d0f925 
Check if the package is excluded before asking for its kind (the latter
might be expensive).

Contributes to eclipse-jdt/eclipse.jdt.ui#1860
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fedejeanne