Skip to content

Conversation

@nickajacks1
Copy link

Support MOSQ_ERR_AUTH_DELAYED for extended auth.
Added mosquitto_complete_extended_auth, which optionally sends auth data. Sadly, there's a bit of code duplication between this and handle__auth. I wasn't sure if it was worth splitting out into a shared segment of code or not.
Added two client states, mosq_cs_delayed_ext_auth and mosq_cs_delayed_ext_reauth. This seemed to be cleaner than trying to use existing client states.
Updated the delayed_auth plugin example to support extended auth.

I commandeered contexts_by_id_delayed_auth a bit. My understanding is that previously, that table was disjoint with contexts_by_id, but that won't work well for reauthentication. Since the same hash handle can't be used for more than one table, I added a new handle.

Maintainers, feel free to modify/discard any portion of this changeset as necessary.

  • Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.
  • If you are contributing a new feature, is your work based off the develop branch?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run make test with your changes locally?

Fixes #3357

Adds a new mosquitto_complete_extended_auth plugin function.

Signed-off-by: Nicholas Jackson <[email protected]>
@nickajacks1
Copy link
Author

I will be available to resolve conflicts only after Nov 1 at the earliest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant