Fix clang-tidy warnings in UDS - #508
Draft
simon-d-bmw wants to merge 1 commit into
Draft
Conversation
simon-d-bmw
force-pushed
the
fix-clang-tidy-phase2-uds
branch
from
July 3, 2026 07:55
4b16897 to
29a4825
Compare
simon-d-bmw
force-pushed
the
fix-clang-tidy-phase2-uds
branch
from
July 3, 2026 11:26
72a4d7c to
7a65e26
Compare
simon-d-bmw
marked this pull request as ready for review
July 3, 2026 11:28
simon-d-bmw
force-pushed
the
fix-clang-tidy-phase2-uds
branch
from
July 3, 2026 11:58
7a65e26 to
62f57d3
Compare
rolandreichweinbmw
previously approved these changes
Jul 3, 2026
simon-d-bmw
force-pushed
the
fix-clang-tidy-phase2-uds
branch
from
July 3, 2026 13:21
62f57d3 to
86770cf
Compare
rolandreichweinbmw
approved these changes
Jul 3, 2026
Contributor
|
Please wait until merge until upcoming UDS refactoring by @christian-schilling is available and merged first. |
rolandreichweinbmw
marked this pull request as draft
July 7, 2026 08:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Description
This PR fixes clang-tidy findings in the UDS module by replacing raw
request arrays and pointer arithmetic with ETL-backed views and
containers, tightening malformed-request validation in affected request
parsing paths, and making implemented-request storage safe during object
construction.
It also updates the related UDS regression tests.
Follow-up request API cleanup is tracked in #510.
Related Issues
#381
#510
Breaking Changes
If there are breaking changes, please explain what they are and how they may impact existing
functionality.
Test Plan
udsTestcoverage for the touched request parsing and bounds handling pathstests-s32k1xx-releaseto confirm the changes compile for the second CI targetRegression Tests
Have tests been added/updated? [x] Yes [ ] No