Quick fix to add available matching version for Imported packages #1962

nburnwal09 · 2025-09-09T08:00:07Z

This is to provide a quick fix for adding the available matching version for Imported packages in MANIFEST.MF warning.
Similar to the fix: #1623 and as suggested in here

Attaching screenshot for the quick fix:

After applying:

github-actions · 2025-09-09T14:01:34Z

Test Results

771 files ±0 771 suites ±0 55m 4s ⏱️ - 1m 14s
3 648 tests ±0 3 594 ✅ +1 54 💤 ±0 0 ❌ - 1
10 878 runs ±0 10 715 ✅ +1 163 💤 ±0 0 ❌ - 1

Results for commit cc2fb8c. ± Comparison against base commit 524971f.

♻️ This comment has been updated with latest results.

nburnwal09 · 2025-09-15T05:16:18Z

@HannesWell
Can you please review this PR?

Corrected:
Also, as you suggested here to provide the version range
I have added a method VersionUtil.computeInitialRequirementVersionRange() and providing version range with minor and major versions as quick fix - for both Required packages and Imported packages

gireeshpunathil · 2025-11-21T11:36:10Z

...e.pde.ui/src/org/eclipse/pde/internal/ui/correction/VersionMatchImportPackageResolution.java

+						exportedPackage.getVersion().toString(), NameVersionDescriptor.TYPE_PACKAGE);
+				exportedPackage.getExporter().getBundle();
+
+				if (("java".equals(name) || name.startsWith("java."))) { //$NON-NLS-1$ //$NON-NLS-2$


can this check be moved to the beginning of the loop, as soon as name is available?

eclipse-pde-bot · 2025-12-01T12:10:32Z

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.core/META-INF/MANIFEST.MF
ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From f296c0b4a4fa6eb57edbc26e6983e65f297b7435 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <[email protected]>
Date: Mon, 1 Dec 2025 12:10:15 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/ui/org.eclipse.pde.core/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.core/META-INF/MANIFEST.MF
index a83a7c3f04..d1d5acc8e3 100644
--- a/ui/org.eclipse.pde.core/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.core/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.pde.core; singleton:=true
-Bundle-Version: 3.21.100.qualifier
+Bundle-Version: 3.21.200.qualifier
 Bundle-Activator: org.eclipse.pde.internal.core.PDECore
 Bundle-Vendor: %provider-name
 Bundle-Localization: plugin
diff --git a/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF
index f8db32e0c6..87bb6898ee 100644
--- a/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.pde.ui; singleton:=true
-Bundle-Version: 3.16.300.qualifier
+Bundle-Version: 3.16.400.qualifier
 Bundle-Activator: org.eclipse.pde.internal.ui.PDEPlugin
 Bundle-Vendor: %provider-name
 Bundle-Localization: plugin
-- 
2.51.2

Further information are available in Common Build Issues - Missing version increments.

HannesWell

Just one point from me at the moment, I'll try to do a full review this evening.

HannesWell · 2025-12-02T07:24:31Z

ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/util/VersionUtil.java

+	public static String computeInitialRequirementVersionRange(String version) {
+		if (version != null && VersionUtil.validateVersion(version).isOK()) {
+			Version pvi = Version.parseVersion(version);
+			return new VersionRange(
+					"[" + pvi.getMajor() + "." + pvi.getMinor() + "," + (pvi.getMajor() + 1) + ")") //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$//$NON-NLS-4$
+							.toString();
+		}
+		return ""; //$NON-NLS-1$
+	}


Recently I added a method that does this to ManifestUtils:

eclipse.pde/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/util/ManifestUtils.java

Lines 402 to 410 in 6a28c28

public static Optional<VersionRange> createConsumerRequirementRange(Version version) {

if (version != null && !Version.emptyVersion.equals(version)) {

return Optional.ofNullable(new VersionRange(VersionRange.LEFT_CLOSED, //

new Version(version.getMajor(), version.getMinor(), 0), //

new Version(version.getMajor() + 1, 0, 0), //

VersionRange.RIGHT_OPEN));

}

return Optional.empty();

}

Admittedly this method would probably better be moved to this class and probably be used instead of the existing method. That would hopefully add proper version ranges in more places.
I can try to have a look at unifying these as soon as possible. Or if you want to have a look at it, it would be more than welcome.

@HannesWell
I have moved your method createConsumerRequirementRange to VersionUtil class and updated the corresponding callers(found 2 classes - JavaResolutionFactory and ImportPackageObject).
Kindly check the changes.

nburnwal09 force-pushed the quickFix_verMatch_import_package branch from cf7ab4f to 6e79a47 Compare September 15, 2025 12:53

nburnwal09 mentioned this pull request Sep 16, 2025

Add N&N - quick fix for addition of available matching version of req… eclipse-platform/www.eclipse.org-eclipse#414

Draft

nburnwal09 force-pushed the quickFix_verMatch_import_package branch 2 times, most recently from de3e456 to 971407a Compare September 23, 2025 16:20

nburnwal09 force-pushed the quickFix_verMatch_import_package branch from f6a6a98 to adb0579 Compare October 6, 2025 06:08

gireeshpunathil reviewed Nov 21, 2025

View reviewed changes

nburnwal09 force-pushed the quickFix_verMatch_import_package branch from adb0579 to 7089fa0 Compare November 24, 2025 05:17

gireeshpunathil approved these changes Nov 24, 2025

View reviewed changes

nburnwal09 force-pushed the quickFix_verMatch_import_package branch from 7089fa0 to 7687e6f Compare December 1, 2025 12:04

gireeshpunathil requested a review from HannesWell December 2, 2025 05:18

HannesWell reviewed Dec 2, 2025

View reviewed changes

Quick fix to add available version for Imported packages

cc2fb8c

nburnwal09 force-pushed the quickFix_verMatch_import_package branch from 35827e3 to cc2fb8c Compare December 13, 2025 13:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Quick fix to add available matching version for Imported packages #1962

Quick fix to add available matching version for Imported packages #1962

nburnwal09 commented Sep 9, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 9, 2025 •

edited

Loading

Uh oh!

nburnwal09 commented Sep 15, 2025 •

edited

Loading

Uh oh!

gireeshpunathil Nov 21, 2025

Uh oh!

nburnwal09 Nov 24, 2025

Uh oh!

eclipse-pde-bot commented Dec 1, 2025

Uh oh!

HannesWell left a comment

Uh oh!

HannesWell Dec 2, 2025

Uh oh!

nburnwal09 Dec 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	public static Optional<VersionRange> createConsumerRequirementRange(Version version) {
	if (version != null && !Version.emptyVersion.equals(version)) {
	return Optional.ofNullable(new VersionRange(VersionRange.LEFT_CLOSED, //
	new Version(version.getMajor(), version.getMinor(), 0), //
	new Version(version.getMajor() + 1, 0, 0), //
	VersionRange.RIGHT_OPEN));
	}
	return Optional.empty();
	}

Quick fix to add available matching version for Imported packages #1962

Are you sure you want to change the base?

Quick fix to add available matching version for Imported packages #1962

Conversation

nburnwal09 commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

nburnwal09 commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gireeshpunathil Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

nburnwal09 Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

eclipse-pde-bot commented Dec 1, 2025

Uh oh!

HannesWell left a comment

Choose a reason for hiding this comment

Uh oh!

HannesWell Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

nburnwal09 Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nburnwal09 commented Sep 9, 2025 •

edited

Loading

github-actions bot commented Sep 9, 2025 •

edited

Loading

nburnwal09 commented Sep 15, 2025 •

edited

Loading