Use root node determined by Parser.parse(IDocument) in UpdateUnitVersions and TargetDefinitionCodeMiningProvider

[trancexpress]

Fixes: #2135

[eclipse-pde-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.genericeditor.extension/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From 3c75e216d5e80d796863d3f97bb846a7413a1dd1 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <[email protected]>
Date: Sat, 6 Dec 2025 13:00:30 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/ui/org.eclipse.pde.genericeditor.extension/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.genericeditor.extension/META-INF/MANIFEST.MF
index cb86c60b2d..443137c0e8 100644
--- a/ui/org.eclipse.pde.genericeditor.extension/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.genericeditor.extension/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.pde.genericeditor.extension;singleton:=true
-Bundle-Version: 1.3.200.qualifier
+Bundle-Version: 1.3.300.qualifier
 Bundle-Localization: plugin
 Require-Bundle: org.eclipse.core.runtime,
  org.eclipse.jface.text,
-- 
2.52.0

Further information are available in Common Build Issues - Missing version increments.

[github-actions]

Test Results

  623 files  ±0    623 suites  ±0   52m 2s ⏱️ - 1m 26s
3 648 tests ±0  3 593 ✅ +1   54 💤 ±0  1 ❌  - 1 
8 213 runs  ±0  8 073 ✅ +1  139 💤 ±0  1 ❌  - 1 

For more details on these failures, see this check.

Results for commit 733d27a. ± Comparison against base commit e442ecb.

♻️ This comment has been updated with latest results.

[merks]

@HannesWell

It looks like the bot is using an outdated message that mentioned 4.38 instead of 4.39:

Version bump(s) for 4.38 stream

[HannesWell]

It looks like the bot is using an outdated message that mentioned 4.38 instead of 4.39:

I assume that's because the version bump commit was already created for the previous release cycle.
@trancexpress could you force push this PR's branch to only your commit so that the bot can recreate the version increment commit from scratch?

[trancexpress]

Right, sorry, had to take the branch from remote. I didn't notice the version bump.

[trancexpress]

Windows test fail in last job is:

 Tests run: 8, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.881 s <<< FAILURE! -- in org.eclipse.pde.api.tools.builder.tests.usage.Java8LambdaUsageTests
org.eclipse.pde.api.tools.builder.tests.usage.Java8LambdaUsageTests.testLambdaExpressionF -- Time elapsed: 0.900 s <<< FAILURE!
junit.framework.AssertionFailedError: Should not be a JDT error: Type mismatch: cannot convert from Comparator<String> to Comparator<? super T>
	at junit.framework.Assert.fail(Assert.java:57)
	at junit.framework.Assert.assertTrue(Assert.java:22)
	at junit.framework.Assert.assertFalse(Assert.java:39)
	at junit.framework.TestCase.assertFalse(TestCase.java:208)
	at org.eclipse.pde.api.tools.builder.tests.ApiBuilderTest.expectingNoJDTProblemsFor(ApiBuilderTest.java:216)
	at org.eclipse.pde.api.tools.builder.tests.usage.Java8UsageTest.deployUsageTest(Java8UsageTest.java:112)
	at org.eclipse.pde.api.tools.builder.tests.usage.Java8LambdaUsageTests.x1(Java8LambdaUsageTests.java:84)
	at org.eclipse.pde.api.tools.builder.tests.usage.Java8LambdaUsageTests.testLambdaExpressionF(Java8LambdaUsageTests.java:67)

[trancexpress]

Latest fail is:

AllPDETests AllLauncherTests PluginBasedLaunchTest.testGetMergedBundleMap_multipleWorkspacePluginVersions_multipleSpecificVersion

expected: 
  {
  plugin.a-1.0.0(w)="default:default",
  plugin.a-2.0.0(w)="default:default"
  }
 but was: 
  {
  org.eclipse.core.contenttype-3.9.800.v20251105-1620(e)="default:default",
  org.eclipse.core.jobs-3.15.700.v20250725-1147(e)="default:default",
  org.eclipse.equinox.app-1.7.500.v20250629-0337(e)="default:default",
  org.eclipse.equinox.common-3.20.300.v20251111-0312(e)="2:true",
  org.eclipse.equinox.preferences-3.12.100.v20251111-0704(e)="default:default",
  org.eclipse.equinox.registry-3.12.600.v20250906-0651(e)="default:default",
  plugin.a-1.0.0(w)="default:default",
  plugin.a-2.0.0(w)="default:default"
  }

Seems to not be related.

[trancexpress]

@iloveeclipse can you take a look here? I think we can merge this and it will reduce some sporadic fails in PDE.

[trancexpress]

Current fail is:

org.eclipse.pde.ui.tests.launcher.PluginBasedLaunchTest.testGetMergedBundleMap_multipleWorkspacePluginVersions_multipleSpecificVersion -- Time elapsed: 0.450 s <<< FAILURE!
org.opentest4j.AssertionFailedError: 

expected: 
  {
  plugin.a-1.0.0(w)="default:default",
  plugin.a-2.0.0(w)="default:default"
  }
 but was: 
  {
  org.eclipse.core.contenttype-3.9.800.v20251105-1620(e)="default:default",
  org.eclipse.core.jobs-3.15.700.v20250725-1147(e)="default:default",
  org.eclipse.equinox.app-1.7.600.v20251211-1038(e)="default:default",
  org.eclipse.equinox.common-3.20.300.v20251111-0312(e)="2:true",
  org.eclipse.equinox.preferences-3.12.100.v20251111-0704(e)="default:default",
  org.eclipse.equinox.registry-3.12.600.v20250906-0651(e)="default:default",
  plugin.a-1.0.0(w)="default:default",
  plugin.a-2.0.0(w)="default:default"
  }
	at org.eclipse.pde.ui.tests.launcher.AbstractLaunchTest.assertPluginMapsEquals(AbstractLaunchTest.java:138)
	at org.eclipse.pde.ui.tests.launcher.PluginBasedLaunchTest.assertGetMergedBundleMap(PluginBasedLaunchTest.java:1095)
	at org.eclipse.pde.ui.tests.launcher.PluginBasedLaunchTest.assertGetMergedBundleMap(PluginBasedLaunchTest.java:1080)
	at org.eclipse.pde.ui.tests.launcher.PluginBasedLaunchTest.assertGetMergedBundleMap(PluginBasedLaunchTest.java:1070)
	at org.eclipse.pde.ui.tests.launcher.PluginBasedLaunchTest.testGetMergedBundleMap_multipleWorkspacePluginVersions_multipleSpecificVersion(PluginBasedLaunchTest.java:285)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at org.eclipse.pde.ui.tests.runtime.TestUtils$1.evaluate(TestUtils.java:267)
	at org.eclipse.pde.ui.tests.runtime.TestUtils$1.evaluate(TestUtils.java:267)
	at org.eclipse.pde.ui.tests.runtime.TestUtils$1.evaluate(TestUtils.java:267)