Skip to content

Fix build block user action (#472) #1743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haideryaqoob720 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix build block user action (#472) #1743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c9bea8
unblock the user actions while running the build
haideryaqoob720 Feb 18, 2025
a549a17
optimize the thread - all the UI interactions are now handle by "main"
haideryaqoob720 Feb 19, 2025
18b6b45
Add isUI method to LockManager for identify UI thread and grant immed…
haideryaqoob720 Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions runtime/bundles/org.eclipse.core.jobs/src/org/eclipse/core/internal/jobs/LockManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,15 @@ public boolean aboutToWait(Thread lockOwner) {
return false;
}

public boolean isUI() {
try {
return lockListener.isUI();
} catch (Exception | LinkageError e) {
handleException(e);
}
return false;
}

/**
* This thread has just acquired a lock. Update graph.
*/
Expand Down
2 changes: 1 addition & 1 deletion runtime/bundles/org.eclipse.core.jobs/src/org/eclipse/core/internal/jobs/ThreadJob.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ static ThreadJob joinRun(ThreadJob threadJob, IProgressMonitor monitor) {
boolean interruptedDuringWaitForRun;
try {
// just return if lock listener decided to grant immediate access
if (manager.getLockManager().aboutToWait(blocker)) {
if (manager.getLockManager().aboutToWait(blocker) || manager.getLockManager().isUI()) {
return threadJob;
}
result = waitForRun(threadJob, monitor, blockingJob);
Expand Down
6 changes: 6 additions & 0 deletions runtime/bundles/org.eclipse.core.jobs/src/org/eclipse/core/runtime/jobs/LockListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@ public boolean aboutToWait(Thread lockOwner) {
return false;
}

/**
Copy link
Member

@akurtakov akurtakov Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to document this new API method and explain in details when/why should one say it's UI . Even if it looks "obvious" - having things written explicitly helps in reducing difference in expectations.

* @since 3.16
*/
public boolean isUI() {
return false;
}
/**
* Notification that a thread is about to release a lock.
* <p>
Expand Down
Loading