Skip to content

feat(cache-maintenance): usable in non-score setups - #181

Merged
AlexanderLanin merged 6 commits into
mainfrom
cache-fix
Aug 8, 2026
Merged

feat(cache-maintenance): usable in non-score setups#181
AlexanderLanin merged 6 commits into
mainfrom
cache-fix

Conversation

@AlexanderLanin

@AlexanderLanin AlexanderLanin commented Aug 6, 2026

Copy link
Copy Markdown
Member

fixes and docs developed during attempt to apply the cache workflows

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds cache workflow fixes, credential compatibility, and integration documentation.

Changes:

  • Adds private-dependency and updated QNX credential support.
  • Documents cache integration and lifecycle behavior.
  • Links the new guide from the README.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
README.md Links the cache-maintenance guide.
.github/workflows/cache-maintenance.yml Updates cache behavior and credentials.
.github/workflows/cache-maintenance.md Adds integration and operations guidance.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/cache-maintenance.yml
Comment thread .github/workflows/cache-maintenance.yml Outdated
Comment thread .github/workflows/cache-maintenance.yml Outdated
@AlexanderLanin
AlexanderLanin marked this pull request as ready for review August 6, 2026 23:48
@AlexanderLanin AlexanderLanin changed the title cache-fix feat(cache-maintenance): usable in non-score setups Aug 6, 2026
Comment thread .github/workflows/cache-maintenance.yml Outdated
Comment thread .github/workflows/cache-maintenance.yml Outdated
Comment thread .github/workflows/cache-maintenance.md Outdated
Comment thread .github/workflows/cache-maintenance.md Outdated
Comment thread .github/workflows/cache-maintenance.md Outdated
Comment thread .github/workflows/cache-maintenance.md Outdated

- name: Create Bazel output base directory
if: ${{ steps.check.outputs.any_changed == 'true' || github.event_name != 'push' }}
if: ${{ steps.check.outputs.any_changed == 'true' || (github.event_name != 'push' && github.event_name != 'workflow_dispatch') }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intention of these conditions is that on pull_requests they always need to be executed for checking input variants. On push events they will only be executed, when MODULE.bazel.lock has changed.

If start to wonder if this condition should be better rewritten like this:

Suggested change
if: ${{ steps.check.outputs.any_changed == 'true' || (github.event_name != 'push' && github.event_name != 'workflow_dispatch') }}
if: ${{ steps.check.outputs.any_changed == 'true' || (github.event_name == 'pull_request' || github.event_name == 'pull_request_target' }}

IMHO it is better to understand when this step is actually run. On the other hand we have to cover this way all event types, which should do dry-runs. Your way is all event types, which should not do dry-runs.

If we decide to act on this all conditions should be changed accordingly.

Comment thread .github/workflows/cache-maintenance.yml
@AlexanderLanin
AlexanderLanin merged commit 0621768 into main Aug 8, 2026
4 checks passed
@AlexanderLanin
AlexanderLanin deleted the cache-fix branch August 8, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants