feat(cache-maintenance): always prune obsolete caches - #187
Merged
Conversation
ans simplify logic via DRY_RUN variable
AlexanderLanin
requested review from
MaximilianSoerenPollak,
PiotrKorkus,
dcalavrezo-qorix,
lurtz,
nradakovic,
opajonk and
pawelrutkaq
as code owners
August 8, 2026 13:56
Contributor
There was a problem hiding this comment.
Pull request overview
Updates cache maintenance so obsolete cache generations are pruned after every cache-writing run.
Changes:
- Centralizes read-only detection in
DRY_RUN. - Separates conditional disk-cache deletion from unconditional obsolete-generation pruning.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lurtz
approved these changes
Aug 10, 2026
lurtz
left a comment
lurtz
left a comment
Contributor
There was a problem hiding this comment.
I tried to prune the caches, when I know new ones have been created to have a fast workflow. Even if pruning caches is a noop it will take some seconds.
Member
Author
|
yeah thats very true. generic usage means its not super optimized for one use case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is absolutely no harm in always pruning obsolete caches. We want to do that after every cache upload anyway. Adding this here will hopefully allow different applications of this workflow.
Incl small refactoring: simplify logic via DRY_RUN variable. This is a no-op change.