[5200] Add support for uploading projects with models referencing each other #5723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
pcdavid
force-pushed
the
pcd/fix/xref-model-upload
branch
2 times, most recently
from
0415b34 to
42489b8
Compare
pcdavid
added
pr: to review soon
priority: high
and removed
pr: to review later
priority: low
labels
pcdavid
force-pushed
the
pcd/fix/xref-model-upload
branch
from
42489b8 to
13c2e23
Compare
sbegaudeau
requested changes
Nov 13, 2025
Comment on lines
27
to
31
| public record UploadDocumentInput(@NotNull UUID id, @NotNull String editingContextId, @NotNull UploadFile file, boolean allowProxies, boolean readOnly) implements IInput { | ||
| public UploadDocumentInput(@NotNull UUID id, @NotNull String editingContextId, @NotNull UploadFile file, boolean readOnly) { | ||
| this(id, editingContextId, file, false, readOnly); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
This is mainly used to communicate between the frontend and backend. It would be very odd to use it to carry strictly internal data hidden from the GraphQL schema. I'll have to retrieve the code and look at it in more details to understand the flow of the code.
Member
Author
There was a problem hiding this comment.
Indeed, it's no longer needed and I forgot to clean it up after rebasing the PR.
It was needed in my initial version, before #5446 rewrote the project import logic: in the old version, ProjectImporter used to import the documents by programmatically creating and sending UploadDocumentInput to the editingContextEventProcessor.
pcdavid
force-pushed
the
pcd/fix/xref-model-upload
branch
from
13c2e23 to
ad20614
Compare
sbegaudeau
approved these changes
Nov 17, 2025
Member
sbegaudeau
left a comment
sbegaudeau
left a comment
There was a problem hiding this comment.
Everything I tried seems to work nicely 👍
sbegaudeau
force-pushed
the
pcd/fix/xref-model-upload
branch
from
ad20614 to
7003e2d
Compare
…h other Bug: #5200 Signed-off-by: Pierre-Charles David <[email protected]>
sbegaudeau
force-pushed
the
pcd/fix/xref-model-upload
branch
from
7003e2d to
6790b9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: #5200
Signed-off-by: Pierre-Charles David [email protected]
General purpose
What is the main goal of this pull request?