Features/fix uart flow control #685
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arfoll
suggested changes
Apr 2, 2017
Contributor
arfoll
left a comment
arfoll
left a comment
There was a problem hiding this comment.
Please fix all the strings that are too long
src/x86/up.c
Outdated
| mraa_up_set_pininfo(b, 9, "GND", (mraa_pincapabilities_t){ 0, 0, 0, 0, 0, 0, 0, 0 }, -1); | ||
| mraa_up_set_pininfo(b, 10, "UART1_RX", (mraa_pincapabilities_t){ 1, 1, 0, 0, 0, 0, 0, 1 }, 15); | ||
| mraa_up_set_pininfo(b, 11, "GPIO17", (mraa_pincapabilities_t){ 1, 1, 0, 0, 0, 0, 0, 0 }, 17); | ||
| mraa_up_set_pininfo(b, 11, "UART1_RTS",(mraa_pincapabilities_t){ 1, 1, 0, 0, 0, 0, 0, 1 }, 17); |
Contributor
There was a problem hiding this comment.
That string is too long for the array, actually a bunch of those are to long already, max size is 7 (as 7+1 == 8 in C with the \0 char).
Contributor
Author
There was a problem hiding this comment.
Hi the maximum name size is 12 character
include/mraa_internal_types.h: char name[MRAA_PIN_NAME_SIZE]; /**< Pin's real world name */
api/mraa/common.h:#define MRAA_PIN_NAME_SIZE 12
Contributor
Author
|
Removed up related changes and put in a separate pull request |
Signed-off-by: Nicola Lunghi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for uart hardware flow control