CMake: Bump min version to 3.1 #914
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed function for setting c++11 standard in favor of using CMake 3.1 global: set (CMAKE_CXX_STANDARD 11) Signed-off-by: Noel Eck <[email protected]>
Contributor
Author
|
It seems like this should also be captured in the mraa.pc file however I'm not sure of the BKM for adding CXXFLAGS to pkg-config. Variable maybe? |
Contributor
|
I guess |
arfoll
approved these changes
Aug 8, 2018
Contributor
arfoll
left a comment
arfoll
left a comment
There was a problem hiding this comment.
I still think dual .pc files is probably the only way here. But the best thing to do would be maybe to find out what other libs are doing before jumping to a solution :)
In the meantime Cmake 3.1 min is a good choice imho
Contributor
Author
|
I'm not going to get to this for a bit (moving). I will wrap it up asap
when settled.
…On Tue, Aug 7, 2018, 11:48 PM Brendan Le Foll ***@***.***> wrote:
***@***.**** approved this pull request.
I still think dual .pc files is probably the only way here. But the best
thing to do would be maybe to find out what other libs are doing before
jumping to a solution :)
In the meantime Cmake 3.1 min is a good choice imho
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#914 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AOqVebN50Gbq_0dZ7Z0_r0JS3cjAf03wks5uOomvgaJpZM4VpjSM>
.
|
Contributor
|
@pylbert, let me bump this up, do you still plan to merge this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed function for setting c++11 standard in favor of using CMake 3.1
global:
set (CMAKE_CXX_STANDARD 11)
Signed-off-by: Noel Eck [email protected]